search

SpyglassMC / Spyglass

Development tools for vanilla Minecraft: Java Edition data pack developers.
https://spyglassmc.com
MIT License
297 stars 31 forks source link

Cannot find `pack.mcmeta` when projectRoot is "complex" #1572

Open SPGoding opened 4 weeks ago

SPGoding commented 4 weeks ago

Example project root that doesn't work: file:///c%3A/Users/foo/AppData/Roaming/.minecraft/saves/%C2%A7a%C2%A7lVersion%201.21%20%C2%A74%C2%A7l%5B4.5%5D%C2%A77/datapacks/bar/, which after percent decoding is file:///c:/Users/foo/AppData/Roaming/.minecraft/saves/§a§lVersion 1.21 §4§l[4.5]§7/datapacks/bar/

Maybe all those percent encoding messed something up?

misode commented 3 weeks ago

This may be the root cause that is causing those unexplained undeclared symbol issues in the few reported cases

misode commented 2 weeks ago

The issue seems to be caused by https://github.com/sindresorhus/globby/issues/81

I didn't immediately find a workaround. We should probably not use glob matching to walk the file tree.

SPGoding commented 2 weeks ago

I assume it should not be too difficult to implement a file tree walk ourselves