Add .mp4 file support - Githubissues

SpykerNZ / one-pace-for-plex

This project helps adapt One Pace to a format plex can read.

79 stars 9 forks source link

Add .mp4 file support #22

Closed cawnj closed 8 months ago

cawnj commented 8 months ago

Describe your changes

Came across this when downloading some episodes from Telegram, which were .mp4 files and not the .mkv files that this script supported.

This change fixes that and allows both .mkv and .mp4 file extensions to work and be renamed correctly.

cawnj commented 8 months ago

looks good. I will probably recompile rename.exe once you merge.

If you could that would be great, tyty

cawnj commented 8 months ago

@SpykerNZ I just realised I introduced a bug in this PR. Python's r-string and rf-string syntax caught me, and I didn't catch the bug since I was testing with Dressrosa episodes, which are exceptions 🤦 Pushed a fix to main anyway so we're good now!

SpykerNZ commented 8 months ago

Good catch! I'm being a bit lazy and just looking at the changes by eye ha.

I've recompiled the .exe and have tested with mp4 files - all looking good there :)