Spyware007 / Animating-Buttons

Explore Amazing Buttons animation for your next project. 🀩An initiative by GDSC-DYPCOE for Hactoberfest. πŸš€
https://buttons-animhub.onrender.com/
MIT License
237 stars 451 forks source link

feat: nav bar theme feature πŸš€βœ¨ #1922

Closed 0xabdulkhaliq closed 1 year ago

0xabdulkhaliq commented 1 year ago

Fixes Issue

Closes #1695

Changes proposed

Screenshots

SAMPLES FROM TWO PAGES
HOME home
ABOUT about

Checklist

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
lets-animate-buttons βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 10, 2023 5:14am
0xabdulkhaliq commented 1 year ago

Note to reviewers πŸ“Œ

Souravvmishra commented 1 year ago

@0xabdulkhalid How can i preview this? there is no difference in my browsers

Souravvmishra commented 1 year ago

Also if it works, can you reduce a little lower color as compared to main color

0xabdulkhaliq commented 1 year ago

If we reduce the color then we can't get the realistic theme effect @Souravvmishra

0xabdulkhaliq commented 1 year ago

@0xabdulkhalid How can i preview this? there is no difference in my browsers

@Souravvmishra I already mentioned about this on PR comment's Changes Proposed section. This feature is still in development for common browsers like Firefox, Chrome. So it won't work for these browsers.

But it can work at browsers like Vivaldi, Chrome for Mobile (you want to disable dark mode for that) Etc.

Souravvmishra commented 1 year ago

Screenshot_2023-08-02-08-28-10-919_com.android.chrome.jpg

No difference @Spyware007 Can You See Any Difference Have a Look

0xabdulkhaliq commented 1 year ago

@Souravvmishra, @Spyware007 πŸ™‚

Screenshot_20230802_121325 Screenshot_20230802_121441
Souravvmishra commented 1 year ago

Please Don't Spam Om is a little busy. He'll look into this asap

Spyware007 commented 1 year ago

@0xabdulkhalid I am not able to see any difference. Could you explain what are you trying to say?

0xabdulkhaliq commented 1 year ago

@Spyware007 in what browser you testing this feature ?

If you're in Chrome for Mobile then you need to Enable Light mode in Theme.

And i already mentioned that "This feature is still in development for common browsers like Firefox, Chrome. So it won't work for these browsers. But it can work at browsers like Vivaldi, Chrome for Mobile (you want to disable dark mode for that) Etc."

0xabdulkhaliq commented 1 year ago

Is anyone here @Souravvmishra, @Spyware007 ?

Contributing period is about coming to an end, Please merge this PR soon.