Weaknesses concerning RECT files

SqAtx / SuperMarioWorld

An amazing 2D Mario game made with C++ and SFML

GNU General Public License v2.0

18 stars 11 forks source link

Weaknesses concerning RECT files #1

Closed SqAtx closed 9 years ago

SqAtx commented 9 years ago

If the line doesn't end with a space, the last field is read as something like 65\nfoo and the next line (which starts with foo) will be ignored.
If there are 3 textures called walk1, walk2 and walk_foo, HowManyLoadedTexturesContainThisName gets confused and returns 3 instead of 2.
If you call GetTextureNameFromStateName with a state name that doesn't appear in the RECT file, it results in a funny memory leak in the textures map.

SqAtx commented 9 years ago

All solved :) Lines don't have to end with a space. If a coordinate is not a number, or if there are too few or too many of them, an error is yielded and it doesn't alter the execution of the program. HowManyLoadedTexturesContainThisName returns the expected number of textures, solving issues 2 and 3.

A texture called "foo1" will be considered an animation with only one texture and will not be aloowed.