Catch exception objects by const reference

SqliteModernCpp / sqlite_modern_cpp

The C++14 wrapper around sqlite library

MIT License

904 stars 156 forks source link

Catch exception objects by const reference #161

Closed zauguin closed 6 years ago

zauguin commented 6 years ago

A version of #160 on the dev branch.

zauguin commented 6 years ago

@Peter-Levine Please review this one. It should fix all the problematic catch statements left in the dev branch.

Peter-Levine commented 6 years ago

@zauguin The dev branch never caused failure on my end since the exceptions are caught by reference, but it's a good idea to catch by const reference.

I can confirm there is no build failure with the patch.