SqliteModernCpp / sqlite_modern_cpp

The C++14 wrapper around sqlite library
MIT License
902 stars 156 forks source link

with C++20 #219

Open 1574354102 opened 2 years ago

1574354102 commented 2 years ago

VS2019, use C++20: std::is_pod_v can't be used, compilation failed. And in VS2019, use C++17: need to #define _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS, otherwise compilation failed. Looking forward to updating,thanks.

codethinki commented 11 months ago

Yout don't need to silence all deprecation warnings

define _SILENCE_CXX20_CODECVT_FACETS_DEPRECATION_WARNING is enough.

Also, they can't just add this define because you need to know that it's using deprecated stuff. Regarding the std::is_pod_v thing idk what you mean by that because ofc sqlite::database is not a POD (plain old data) type.