search

Sqon / sqon

Reads and writes Sqons.
40 stars 2 forks source link

DirectoryIterator causes an exception when run in HHVM. #2

Closed kherge closed 8 years ago

kherge commented 8 years ago

When using HHVM, this PHP bug from 2014 seems to reveal itself. This error does not occur in any supported version of PHP.

PHPUnit 4.5.0 by Sebastian Bergmann and contributors.

Configuration read from /home/travis/build/kherge/sqon/phpunit.xml.dist

................E....................

Time: 4.56 seconds, Memory: 17.41Mb

There was 1 error:

1) Test\Sqon\Iterator\DirectoryIteratorTest::testIteratoReturnsPathManagersForDirectoriesAndFiles
UnexpectedValueException: Objects returned by RecursiveIterator::getChildren() must implement RecursiveIterator

/home/travis/build/kherge/sqon/src/Sqon/Iterator/DirectoryIterator.php:73
/home/travis/build/kherge/sqon/tests/Sqon/Iterator/DirectoryIteratorTest.php:34

FAILURES!                            
Tests: 37, Assertions: 61, Errors: 1.
kherge commented 8 years ago

Fixed by ff941c8.