feat: improve a11y - Githubissues

Sqrrl / wc-datepicker

A small, accessible and customizable datepicker written in TypeScript.

https://sqrrl.github.io/wc-datepicker

MIT License

54 stars 6 forks source link

feat: improve a11y #27

Closed remischwartz closed 2 weeks ago

remischwartz commented 2 months ago

Closes #25 Covers the following:

Add an aria-label attribute to the th elements. The abbr attribute is not announced by all screen readers.
Only change the value of the hidden span in wc-datepicker__header when the selected value changes (currently, it changes when users navigate through the dates with the keyboard).
In range mode, change the value of the hidden span in wc-datepicker__header to express the selected range (e.g., “June 21, 2024 to June 25, 2024”).
Add a title attribute to the month and year selection fields (same value as the aria-label).

Sqrrl commented 2 months ago

Hey, sorry for the late response and thanks for the PR. Much appreciated. There are failing tests. Could you have another look, please? https://github.com/Sqrrl/wc-datepicker/actions/runs/9659241059/job/27163642464?pr=27

remischwartz commented 1 month ago

Hey, sorry for the late response and thanks for the PR. Much appreciated. There are failing tests. Could you have another look, please? https://github.com/Sqrrl/wc-datepicker/actions/runs/9659241059/job/27163642464?pr=27

Hi, Sorry for the delay. I updated the tests, although I am having trouble testing the month select value.

Sqrrl commented 2 weeks ago

Thanks. Merged this one. Should I wait with the release for https://github.com/Sqrrl/wc-datepicker/pull/28? Has only one unresolved issue.