search

Squachen / micloud

Library for connecting to xiaomi cloud.
MIT License
152 stars 18 forks source link

improve Acces denied #3

Closed starkillerOG closed 3 years ago

starkillerOG commented 3 years ago

I did some additional testing with explicitly supplying wrong password and username. This now actually catches the wrong password/usernames

starkillerOG commented 3 years ago

@Squachen sorry, I did not expect to have it merged so soon, was not yet fully done with testing. I schould have waited before making the PR.

Squachen commented 3 years ago

@starkillerOG Nah sorry, that's on me. Wanted to get a new version pushed asap since I'm at the right computer atm but don't know if I will be for the next couple of days. Is it ready for merge/version update now?

Edit: I've tested it with both simulated connection errors and invalid credentials and it seems to catch the access denied correctly. Merging and updating now so you don't have to wait a few days until I'm back at this pc.