Squad-Wiki / squad-wiki-pipeline-map-data

Creative Commons Attribution Share Alike 4.0 International
30 stars 7 forks source link

Chora Insurgency v1 incorrect main coords #79

Closed mahtoid closed 9 months ago

mahtoid commented 10 months ago

Every other layer is correct

image

Shanomac99 commented 10 months ago

Team 1 main lines up.

Team 2 main does not line up with data in SDK. Verified data present in JSON is the same as in SDK. Unsure if issue is with the data or with Squad Maps.

mahtoid commented 10 months ago

@Shanomac99 So there was a slight issue with SquadMaps which I have fixed and pushed to our dev branch. However, there still seems to be an issue. Quite a lot of incorrect mains or missing mains captured from pipeline.

Chora and Fallujah seem to be correct, but the rest seem to have issues. Screenshots below are SquadMaps v2 vs SquadMaps v1 (which could be slightly outdated).

Al Basrah (multi mains, missing spawn)

image image

Gorodok (missing spawns)

image image

Kokan (double main)

image image

The other maps contain issues too, but those two repeat. I wonder if it is a one or two solve, solves all.

Shanomac99 commented 10 months ago

@mahtoid Minus the multiple points none of the positions are incorrect right? They all look correct to me.

I have a suspicion that i’m logging something incorrectly with insurgency main points. I’ve also noticed there are a few blank elements in the JSON for Chora, might be related.

I also need to think about “resupply” points. I’ll take a look to see what they consist of and see if we can separate them from mains.

mahtoid commented 10 months ago

@Shanomac99 I'd say they are either missing or multiple - not incorrect, sure.

Shanomac99 commented 10 months ago

@mahtoid Perfect, just making sure there aren’t any like halfway across the map when they are supposed to be in a corner.

Shanomac99 commented 10 months ago

@mahtoid Does Squad Maps utilize the objects object for detecting where to put mains? Or just the location within the objective object?

The objects in the capture points are the points where the point is "capturable", or for mains where vehicles can grab supplies.

That could be why there are multiple mains.

Shanomac99 commented 10 months ago

@mahtoid As for the missing "points" it looks like those are temporary spawn points which are not currently logged. Looks like there is also a "maxNum" of vehicles for the vehicle spawners. I'm going to create new issues for these two, as they aren't neccessarly a bug.

mahtoid commented 9 months ago

Does Squad Maps utilize the objects object for detecting where to put mains? Or just the location within the objective object?

capturePoints.objectives[_Main_].objects

Shanomac99 commented 9 months ago

capturePoints.objectives[_Main_].objects

You should be using the cords found in the Main objectives themselves, not the inner objects. Like I said above those boxes/spheres are used for determining where people can rearm vehicles.

mahtoid commented 9 months ago

Ah yeah, true. Once the temporary spawns is captured as well (in your other issue), then this is grand.

Shanomac99 commented 9 months ago

Other two issues were solved, closing this.