Fix shm namespace issue in macOS

Squadrick / shadesmar

Fast C++ IPC using shared memory

MIT License

550 stars 84 forks source link

Fix shm namespace issue in macOS #24

Closed shrijitsingh99 closed 4 years ago

shrijitsingh99 commented 4 years ago

Fixes the failing macOS builds

Also wondering why is shm::memory::dragons disable for macOS? I was able to run dragons benchmark without any issues after enabling it for macOS.

Squadrick commented 4 years ago

@shrijitsingh99 Initially, dragons was using some Linuxism for low-level copying, I think it was calling __memmove_avx_unaligned_erms directly. The compile guards can be removed now. I'll remove it on a succeeding commit.

Thanks for this fix. You might be interested in reading this blog on dragons I wrote recently.

shrijitsingh99 commented 4 years ago

Thanks for this fix. You might be interested in reading this blog on dragons I wrote recently.

Definitely, I was super impressed to see transfer speeds of 100GB/s on my laptop. Will catch up on your work and hopefully look into some areas where I can contribute to,