Cancelation realloc and current member state check/retain

Squads-Protocol / v4

Squads V4

https://v4-sdk-typedoc.vercel.app

GNU Affero General Public License v3.0

89 stars 32 forks source link

Cancelation realloc and current member state check/retain #104

Closed ogmedia closed 3 months ago

ogmedia commented 5 months ago

Cancellation is blocked if new threshold exceeds space when proposal was first created. It's an edge case, but this will block the ability to cancel and thus reclaim rent. We propose adding a proposal_cancel_v2 for this specific realloc, but that requires a system_program account, thus adding a new account context.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-sdk-typedoc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2024 1:31pm

ogmedia commented 5 months ago

Will change this to be ProposalVoteV2

ogmedia commented 5 months ago

@vovacodes @bguillaumat the updates slated here for the realloc introduce some duplications, but mainly because i'm not sure what we're thinking for the future. Since this is already an edge case, i'm thinking we maybe change the account contect to ProposalCancel, and use that in the proposal_cancel_v2 ix. Then we can rip out all of the approve/reject from it. Lmk.