Improvements to chapter 19 (Commander: A Powerful and Simple Command Framework)

SquareBracketAssociates / BuildingApplicationWithSpec2

A book to build user interfaces using the Spec 2.0 framework.

20 stars 12 forks source link

Improvements to chapter 19 (Commander: A Powerful and Simple Command Framework) #65

Closed koendehondt closed 2 months ago

koendehondt commented 2 months ago

Apart from several improvements, I removed a few paragraphs that were very confusing. I added inline review comments to indicate the paragraphs I removed.

Open issues:

testRemoveContact under "Adding the Remove Contact command" is not a good test. The initial items are not specified and more importantly, the test does not verify that the selected contact has been removed. It just checks that there is one contact less than initially.
Under "Enabling shortcuts", it reads "At the time of writing this chapter, Commander management of shortcuts has not been pushed to Spec to avoid dependency on Commander.". Is that still correct? I did not check that yet.
This chapter mentions toolbars, but it does not add a toolbar to a window.

Ducasse commented 2 months ago

It would be good to push the changes to the booklet commander

Ducasse commented 2 months ago

May be we should move the class >> defaultSpec to the instance side

koendehondt commented 2 months ago

Do you refer to this change?

EgContactBookPresenter class >> defaultSpec

ContactBookPresenter class >> defaultLayout

which should have been 🙄

ContactBookPresenter >> defaultLayout

I will fix that.

Ducasse commented 2 months ago

Yes normally we have move the spec to the class and indeed we should check all the spec and turn them into layout.

koendehondt commented 2 months ago

ContactBookPresenter class >> defaultLayout I will fix that.

Fixed in https://github.com/SquareBracketAssociates/BuildingApplicationWithSpec2/commit/e86678d165b05632b9f34babe3df63652a7aecdf