search

SquareBracketAssociates / BuildingApplicationWithSpec2

A book to build user interfaces using the Spec 2.0 framework.
20 stars 12 forks source link

Finish chapter "Lists, tables and trees" #98

Closed koendehondt closed 1 month ago

koendehondt commented 1 month ago
Ducasse commented 1 month ago

I will have a look.

Ducasse commented 1 month ago

Are you sure about this asStringOrText (it looks not really nice to my eyes)?

koendehondt commented 1 month ago

Are you sure about this asStringOrText (it looks not really nice to my eyes)?

Yes, I am sure. I checked all the code, so also this part. I was surprised too 😄.

See SpListPresenter>>#initialize:

initialize

    super initialize.
    self initializeTSearchable.
    autoDeselect := true.
    allowToSelect := true.
    display := [ :object | object asStringOrText ]
koendehondt commented 1 month ago

@Ducasse I added all examples of this chapter to the code repo. See ListTableAndTreeExamples. Doing so, I found a few issues in the text. I fixed them. See the latest commits.

Ducasse commented 1 month ago

In fact I would introduce a method that call Smalltalk globals allClasses because we should remove this Smalltalk variable in the future.