search

SquareBracketAssociates / EnterprisePharo

A new book describing Pharo librairies to make business.
http://books.pharo.org/enterprise-pharo/
Other
71 stars 24 forks source link

Printed version some comments #102

Closed jecisc closed 8 years ago

jecisc commented 8 years ago

I saw two things that can be improved so far:

1)

https://github.com/SquareBracketAssociates/EnterprisePharo/blob/master/PillarChap/Pillar.pillar#L533 https://github.com/SquareBracketAssociates/EnterprisePharo/blob/master/PillarChap/Pillar.pillar#L539

Maybe "My working script" is a better English. If you agree I can do a PR to correct it.

2) This seems to be a Pillar or sbabook issue. Scripts with captions appears in the Illustration table. For example page viii there is a reference to a script page 220.

@DamienCassou

cdlm commented 8 years ago

For 2) it's a feature. That script has a label, meaning it's referenced somewhere, so it has to appear in the table of illustrations (which centralizes all labeled floats with no distinction of type)

jecisc commented 8 years ago

Don't you think it should be renamed "Illustrations and scripts" if it's a feature?

cdlm commented 8 years ago

Sure, why not "Illustrations, figures, tables, and scripts (and whatever)" :trollface:

DamienCassou commented 8 years ago

Thanks Cyril. I agree with Damien that 2) is fine.