search

SquareBracketAssociates / LearningOOPWithPharo

Learning Object-Oriented Programming with Pharo
65 stars 21 forks source link

Companion image shows incomplete code for method #51

Open offray opened 4 years ago

offray commented 4 years ago

While the text on the page is complete showing this:

MyExampleSetTest >> testRemove
  | full |
  full := Set with: 5 with: 6.
  full remove: 5.
  self assert: (full includes: 6).
  self deny: (full includes: 5)

The companion image (6.1) on the same page, shows the complete code without the first two lines, as shown here:

which can be a little confusing, when the learner is reading and finds the image not fully including the method source, despite of having space for that. Would be advisable to include a screenshot with the complete source of the method. I have provided it here:

SergeStinckwich commented 4 years ago

Can you do a PR instead?

offray commented 4 years ago

Not at the moment. I'm reading the book in a quick way, and would not have time for dealing directly with the book source code and learning Pillar markup. I will keep reporting issues and if I have time and they have not being solved, I'll try doing PR to solve them.