search

Squarespace / less-compiler

Less compiler in Java
Apache License 2.0
19 stars 9 forks source link

Ampersand selector not working properly #1

Closed riyazshaikh closed 8 years ago

riyazshaikh commented 8 years ago 
.collection-layout-default {
    #header {
        .header-palette-banner& {
            /* styles */
        }
    }
}

​ Currently outputs (v1.3.3 on Squarespace) .header-palette-banner .collection-layout-default #header{ /*styles */ } ​

Should be .header-palette-banner.collection-layout-default #header{ /*styles */ } ​

phensley commented 8 years ago

Thanks @riyazshaikh I'll take a look.

phensley commented 8 years ago

I have a fix for this in code review, should be merged today.

riyazshaikh commented 8 years ago

Awesome! But is this on production branch (v1.3.3) or your own feature branch (v2.4)?

phensley commented 8 years ago

Code is on the internal repository for review, then I'll push it here. This is a fix for the 1.x branch (1.3.3). The bug doesn't exist on master (2.4.0)

phensley commented 8 years ago

Hey @riyazshaikh I've released 1.0.18 which includes the fix to the ampersand bug. This should go out with the next deploy, probably in a few hours. I'll update when it hits production.

riyazshaikh commented 8 years ago

Verified in production. Thanks a lot!