Password envvars created by pgbedrock generate should convert dashes to underscores

Squarespace / pgbedrock

Manage a Postgres cluster's roles, role memberships, schema ownership, and privileges

https://pgbedrock.readthedocs.io/en/latest/

Other

313 stars 35 forks source link

Password envvars created by pgbedrock generate should convert dashes to underscores #18

Closed zcmarine closed 6 years ago

zcmarine commented 6 years ago

Various tools like Bamboo do not like dashes used in variable names. As a result, in those use cases the variable for the envvar has to be manually changed in the spec.yml to use these tools.

While it's feels lousy to name the envvar differently from the role it represents, it feels like the better option for usability of the tool.

This should be a pretty easy fix: basically just adding a .replace('-', '_') to this line and verifying that there is test coverage of that change.

zcmarine commented 6 years ago

This was completed via PR #27 a few weeks ago; I forgot to circle back and close this at the time so doing that now.