Squarespace / pgbedrock

Manage a Postgres cluster's roles, role memberships, schema ownership, and privileges
https://pgbedrock.readthedocs.io/en/latest/
Other
313 stars 35 forks source link

block test suite on dockerized test db explicitly #19

Closed cpdean closed 6 years ago

cpdean commented 6 years ago

If you have a Postgres server running on 5432, docker for mac will silently fail to setup the port forwarding and the original server will intercept traffic intended for the test db that runs in a docker container.

By removing the port from getting forwarded and making the "wait_for_postgres" target connect to the test db through docker's networking, processes on the host will no longer interfere with the test suite.

I removed port forwarding in general from the setup of the test db which I'm not sure is ideal, but I'd like to work through some usability issues that this brings up if anyone can see problems with it.