search

Squarespace / pgbedrock

Manage a Postgres cluster's roles, role memberships, schema ownership, and privileges
https://pgbedrock.readthedocs.io/en/latest/
Other
316 stars 35 forks source link

Formally support Postgres 10 #35

Closed zcmarine closed 6 years ago

zcmarine commented 6 years ago

Overview Prior to this PR Postgres 10 still worked with pgbedrock, but pgbedrock's test suite would fail with a Postgres 10.x docker container. This was due to new roles that were introduced by Postgres 10 which the test infrastructure did not know to expect. As a result, those roles caused test failures.

This PR updates the test infrastructure to properly account for these new roles, allowing us to formally support Postgres 10 from here on out.

There are also a few other tiny commits in this PR that are vaguely related: adding better spacing between the test output for each Postgres version, clarifying a comment in a test, and renaming a fixture.

Feedback I'm Looking For Nothing really; this is mostly just to make y'all aware of the addition of formal pg10 support. Given that this PR just fixes some small things in tests it probably doesn't merit a lot of review.

zcmarine commented 6 years ago

After merging PR #36 (Build docs during Travis CI), I've rebased this branch off master. Other than that no new changes were added.