Correct schema name quoting

Squarespace / pgbedrock

Manage a Postgres cluster's roles, role memberships, schema ownership, and privileges

https://pgbedrock.readthedocs.io/en/latest/

Other

311 stars 35 forks source link

Correct schema name quoting #44

Closed Gastove closed 5 years ago

Gastove commented 5 years ago

Currently, certain ALTER... SCHEMA statements will fail if they address a schema whose name contains a hyphen, which can happen, for instance, managing the personal schema of a user whose name contains a hyphen. This commit wraps the schema name in quotes for the two affected sql queries, and bumps pgbedrock to 0.3.2.

Closes #43.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 172

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals
Change from base Build 167:	0.0%
Covered Lines:
Relevant Lines:	0

💛 - Coveralls

Gastove commented 5 years ago

This isn't going to fix the problem, which is very deep, and gets us in to complex questions of YAML and deep restructurings. This seems unrelated to #7; in fact it is entirely about that, way down in the guts.