NSIS sample does not extract- failure not handled

Squiblydoo / debloat

A GUI and CLI tool for removing bloat from executables

BSD 3-Clause "New" or "Revised" License

301 stars 25 forks source link

NSIS sample does not extract- failure not handled #20

Closed Squiblydoo closed 7 months ago

Squiblydoo commented 10 months ago

In using debloat I identified that this NSIS installer did not extract properly: SHA256: F4A2677E8411FCE6307CDC54A814331BB281D3DD9EA797A4F4BB9D4A496A92CE

The NSIS file could be extracted with Binary Refinery.

[x] Review current errors, implement error handling for future.
[x] Resolve issue causing error.
[x] Find additional NSIS files to confirm that issue is resolved and confirm that other NSIS files extract successfully.

Squiblydoo commented 10 months ago

I identified the bug and created the branch "NSIS-Bug-fix". Review that branch for more information. A fix has been implemented and appears to be working excellently. I tested the fix to confirm that the file mentioned above and previous testing samples work completely. The other two checks remain: namely, implement better error handling and find even more NSIS files to test with.

Squiblydoo commented 10 months ago

Released 1.5.3.1 which resolved the problems I had identified. It seemed worth having the fix out earlier even if I haven't gotten all the error handling in place.

Squiblydoo commented 7 months ago

Forgot to update. But as far as I can tell, this feature is working as expected.