search

Squiblydoo / debloat

A GUI and CLI tool for removing bloat from executables
BSD 3-Clause "New" or "Revised" License
337 stars 28 forks source link

FIx runtime error of debloat-gui on 3.13 #44

Closed clin1234 closed 2 months ago

clin1234 commented 3 months ago

tkinterdnd2 on PyPI refers to https://github.com/Eliav2/tkinterdnd2, which will not run on 3.13. Until I can assume ownership of the package on PyPI, please use my fork: https://github.com/clin1234/tkinterdnd2

Squiblydoo commented 3 months ago

I appreciate the heads up that it will not run on 3.13. Do you use debloat-gui? Or did you find my project another way?

Why do you think you will take ownership of the PyPI package? It looks like your only improvements to tkinterdnd2 were yesterday with no prior history of commits or pull requests to the other tkinterdnd2 repositories.

clin1234 commented 3 months ago

I appreciate the heads up that it will not run on 3.13. Do you use debloat-gui? Or did you find my project another way?

Why do you think you will take ownership of the PyPI package? It looks like your only improvements to tkinterdnd2 were yesterday with no prior history of commits or pull requests to the other tkinterdnd2 repositories.

I do use debloat-gui. Also, the source repository that tkinterdnd2 refers to has seen no activity over the past year.

Squiblydoo commented 3 months ago

Awesome, as far as I knew, no one actually used debloat-gui, so it is good to know. (I figured folk may just use the CLI or the built binaries.)

You are right, tkinterdnd2 really hasn't been maintained at all in the last 4 years. I looked a fair bit at the history of issues and pull requests without any comments.

No offense to you, but I may fork tkinterdnd2 and use my fork. I also opened an issue on Eliav2's fork regarding maintenance.

In regards to your fork, in my opinion, Tix/ Tk.tix needs to be entirely removed. (Tix itself has not been maintained in 10+ years.) Your changes so far only appear to be a small way to get around the issues.

Do you use tkinterdnd2 in your own projects? I couldn't find out for sure from looking at your public repositories. If not, in my opinion, it may make more sense for me to maintain it since I use it with debloat and other projects.

clin1234 commented 3 months ago

Awesome, as far as I knew, no one actually used debloat-gui, so it is good to know. (I figured folk may just use the CLI or the built binaries.)

You are right, tkinterdnd2 really hasn't been maintained at all in the last 4 years. I looked a fair bit at the history of issues and pull requests without any comments.

No offense to you, but I may fork tkinterdnd2 and use my fork. I also opened an issue on Eliav2's fork regarding maintenance.

In regards to your fork, in my opinion, Tix/ Tk.tix needs to be entirely removed. (Tix itself has not been maintained in 10+ years.) Your changes so far only appear to be a small way to get around the issues.

Do you use tkinterdnd2 in your own projects? I couldn't find out for sure from looking at your public repositories. If not, in my opinion, it may make more sense for me to maintain it since I use it with debloat and other projects.

Go ahead; my fork is only used to get debloat-gui running on 3.13

Squiblydoo commented 2 months ago

I submitted a fix to Eliav2 for TkinterDnD2 last week. I'm going to give him a week or so more before I try harder to implement an alternative solution, such as making a new PyPI package, or simply including the required files. So while it is on my radar as something that needs fixed soon, it is my understanding that 3.13 is planned to be in full release October 01, 2024 so for most users, I have a little wiggle room before needing to have it fully implemented.

Is it safe to assume you have a temporary work around to run it locally? If not, I can prioritize getting the fix out sooner, but my perception is that you've already made a work around for now.

clin1234 commented 2 months ago

I submitted a fix to Eliav2 for TkinterDnD2 last week. I'm going to give him a week or so more before I try harder to implement an alternative solution, such as making a new PyPI package, or simply including the required files. So while it is on my radar as something that needs fixed soon, it is my understanding that 3.13 is planned to be in full release October 01, 2024 so for most users, I have a little wiggle room before needing to have it fully implemented.

Is it safe to assume you have a temporary work around to run it locally? If not, I can prioritize getting the fix out sooner, but my perception is that you've already made a work around for now.

I do have a workaround locally

Squiblydoo commented 2 months ago

I am now a maintainer of tkinterdnd2. tkinterdnd2, as of 0.4.0 now works properly with python3.13. I confirmed that debloat-gui worked as expected on Linux and Mac with the new tkinterdnd2.

Thanks again for raising the issue, feel free to open additional issues regarding tkinterdnd2 or debloat.