Closed Aaron1011 closed 7 years ago
Are you sure this resolves the issue? It doesn't look like Forge's FakePlayer
is registered with EntityRegistry
either.
@SquidDev: While technically FakePlayer
should be registered too, we're able to special-case it since we know it will always exist (in Forge). Unregistered mod-added entities, however, prevent us from being able to accurately report details in Timings, without guessing at the mod id.
I've pushed a commit which hopefully fixes this, I'm slightly confused though: ToolHostPlayer
extends FakePlayer
so would it not be caught by the FakePlayer
handler? I haven't looked through Sponge/Timing's code in great detail so don't know.
@SquidDev: The registration is done against the class, so handling the superclass won't catch it. Additionally, it allows us to provide a more specific breakdown in Timings (e.g. grouping entities by the owning mod).
This is causing issues with SpongeForge, which uses entity registration information for things like Aikar's Timings.