search

SquidDev-CC / CCTweaks

Random additions to ComputerCraft (somewhat deprecated, use CC-Tweaked if you're on Minecraft 1.12).
MIT License
12 stars 2 forks source link

Config and Patcher #44

Closed SquidDev closed 9 years ago

SquidDev commented 9 years ago

Closes #41 and closes #42.

This rewrites the config and patching systems to use the ConfigGen and Patcher modules. The aim is to implement as many tweaks as possible without having to reload the game. To quote #3:

To consider: Use config variables rather than changing the raw ASM as it means MC does not have to be reloaded. How much slower is it?

SquidDev commented 9 years ago

I haven't found any problems with this, so am I OK to merge @ElvishJerricco?

JomerDev commented 9 years ago

Quick suggestion for the config: Could you make an option for all the pushRemote and pullRemote commands? So the bridge works for connecting, but not to push and pull remotely

SquidDev commented 9 years ago

Already done! The config name isn't great but I'm pretty bad at describing things.

JomerDev commented 9 years ago

Ohh. I just looked at the commit but didn't see it -_-

ElvishJerricco commented 9 years ago

Took a quick look, and it seems fine. Go ahead