SquidDev-CC / CCTweaks

Random additions to ComputerCraft (somewhat deprecated, use CC-Tweaked if you're on Minecraft 1.12).
MIT License
12 stars 2 forks source link

Maven dependencies are wrong. #53

Closed ElvishJerricco closed 9 years ago

ElvishJerricco commented 9 years ago

As it is, ComputerCraft is the ONLY compile dependency listed, which is the opposite of what it should be. Maven won't use the ivy repository listed in Gradle to look for dependencies. Using CC-Tweaks' maven repo as a dependency in Gradle won't ever build, and will fail to compile against the various other dependencies.

ElvishJerricco commented 9 years ago

I assume it's because of this line? I imagine that's supposed to be removing the CC dependency, but in reality it's making CC the only dependency.

SquidDev commented 9 years ago

It was doing what it was meant to be doing: CC should be the only dependency. However I should just be removing all compile dependencies.

I was trying to ensure the shade and packaged dependencies never got included, but CC shouldn't be included either.

SquidDev commented 9 years ago

Re-uploaded, looks like it is fixed.

ElvishJerricco commented 9 years ago

But why not declare all the maven dependencies such as the ChickenBones stuff?

SquidDev commented 9 years ago

There not 'run-time' dependencies, simply compile time, and so it seems to make more sense to only define the ones to run at minimal functionality.