Modem not turning red when connected

[JomerDev]

Sorry guys, I have another bug report ;P The modems in the newest version don't turn red when connected to a peripheral. I removed CCTweaks and they all turned red, so it is definetly caused by CCTweaks.

[SquidDev]

Sorry to be a pain, but if you connect it and re-log, does it turn red? Also, if you use rednet.connect(side) does it turn red then?

Also, can you duplicate this behaviour for multipart modems? (try placing two modems in one block and turn one on).

[JomerDev]

No problem at all :D I want the problem fixed as fast as you do and know how easy something can go wrong, so... I'll edit the results into this comment as soon as I have them. It should be in about 5 minutes

[SquidDev]

Thanks for taking the time to report them! All I can say is 'it works on my machine'!

[ElvishJerricco]

I've also observed this but forgot to report it. For me, this is the case with both TileCable modems and multipart modems. I think it was actually turning the wrong part red (the part meant for signifying that rednet has opened a channel)

[SquidDev]

So there are several possible causes for this:

• Forgetting to sync the state change - if it changes after a relog then this is probably the case
• Not redrawing - this shouldn't occur, but is a possibility

Better test again then.

Offtopic: @ElvishJerricco I'm writing a thing. Its an attempt to compromise between horrible peripheral code and inefficient reflection by generating the code at compile time.

[SquidDev]

Right, went to try it and it happened first time. Sigh

[JomerDev]

Well, this seems a bit messed up. It sometimes works for me and sometimes doesn't. It also seems that reloging helps. But not all the times. Sometimes it works directly after placing and sometimes it doesn't

You guys have the wierdest bugs :D

[ElvishJerricco]

Oh that's brilliant. Love it. I'll take a look at the code in detail when I get back to my laptop.

[SquidDev]

@Nathan1852

reloging helps. But not all the times.

Hmmm, it should. Odd

@ElvishJerricco It doesn't work yet, I'm copying large potions of my luaj.api project, but there is still lots of work to be done (the test classes don't totally compile yet).

---

So markForUpdate must be being called, otherwise chat messages wouldn't appear. So either the state isn't being refreshed correctly or the packet isn't being sent.

It is late here over the pond and I have a summer job tomorrow so I'm probably going to go to bed and have a look later. Sorry :frowning:.

[JomerDev]

It maybe helps all the time. I think i just didn't connect the modems that didn't work after reloging, but I crashed with something unrelated before I could find out...

[JomerDev]

You guys are crazy fast with bugfixes. Thank you for that

[SquidDev]

It was only one line. Stupid mistake on my part :facepunch:. Hehehe, not my fault: 0f4d29e0a4f1b210e6a82c268a8c76404a9f24b8 :stuck_out_tongue:. I can't reproduce with mutliparts, though I'll have a look tomorrow.

Here you go And auto-uploading to curse works (pending moderation)!