SquidDev-CC / CCTweaks

Random additions to ComputerCraft (somewhat deprecated, use CC-Tweaked if you're on Minecraft 1.12).
MIT License
12 stars 2 forks source link

Wireless bridge for Pocket Computers #56

Closed SquidDev closed 9 years ago

SquidDev commented 9 years ago

Using Peripherals++'s Pocket computer upgrade. We can use the same API format as turtles, but scan the inventory or use the slot to the right or something to find a valid card.

I think the only issue with this is that players do not have an integer position, and so IWorldPosition is inaccurate.

austinv11 commented 9 years ago

If you end up doing this, please feel free to give me feedback about the api! Also, submit a PR to edit this as you would for turtle upgrades.

SquidDev commented 9 years ago

@austinv11 Do you have a maven repo? Just making mods a dependency using curse downloads is kinda annoying.

austinv11 commented 9 years ago

I do with collective framework, but I guess I can create a repo for peripherals++ too On Jul 25, 2015 2:53 PM, "SquidDev" notifications@github.com wrote:

@austinv11 https://github.com/austinv11 Do you have a maven repo? Just making mods a dependency using curse downloads is kinda annoying.

— Reply to this email directly or view it on GitHub https://github.com/SquidDev-CC/CC-Tweaks/issues/56#issuecomment-124872272 .

SquidDev commented 9 years ago

Ahh, here? Great!

austinv11 commented 9 years ago

Yup. When I get back home in a few hours I could set up the Peripherals++ one. On Jul 25, 2015 2:57 PM, "SquidDev" notifications@github.com wrote:

Ahh, here http://jcenter.bintray.com/com/austinv11/collectiveframework/CollectiveFramework/ ?

— Reply to this email directly or view it on GitHub https://github.com/SquidDev-CC/CC-Tweaks/issues/56#issuecomment-124872601 .

austinv11 commented 9 years ago

Here you are: http://jcenter.bintray.com/com/austinv11/peripheralsplusplus/PeripheralsPlusPlus/

SquidDev commented 9 years ago

@austinv11 Thanks! I'm probably being really stupid - but how do you create a pocket computer with a peripheral? - I can't find a crafting handler for it.

austinv11 commented 9 years ago

What do you mean? In game?

SquidDev commented 9 years ago

Yeah. I'm probably being stupid but crafting doesn't seem to work. Thanks for merging!

austinv11 commented 9 years ago

Just craft a pocket computer with the peripheral of choice, however make sure that it isn't a wireless pocket computer!

SquidDev commented 9 years ago

Hmmm, I'll test in a non-dev environment but I can't seem to get it to work. 167 is the latest correct. I found the handler. Was looking for IRecipe instead!


On another note: Unknown recipe class! com.austinv11.peripheralsplusplus.recipe.ContainerRecipe Modder please refer to net.minecraftforge.oredict.RecipeSorter You need to register your handler. I know it is odd having to do it twice.

austinv11 commented 9 years ago

Hm, you may need to add some command line arguments then, particularly this: -Dfml.coreMods.load=com.austinv11.collectiveframework.minecraft.asm.CollectiveFrameworkEarlyTransformerPlugin,com.austinv11.peripheralsplusplus.asm.PeripheralsPlusPlusTransformerPlugin

Although the coremods should be loading since your running pre-compiled versions of the mod

SquidDev commented 9 years ago

Its finding the Peripherals++ one, but not CollectiveFramework. You are doing some pretty dark magic in some of the CollectiveFramework classes :stuck_out_tongue_winking_eye:. Ahh, so it isn't calling producing the FindMatchingRecipeEvent event. IRecipe exists for a reason :smile:.

austinv11 commented 9 years ago

Interesting...Gonna need to see why it isn't working with CollectiveFramework, and yes I am ;) I wish some of the hackiness wasn't required but coremods make everything weird.

SquidDev commented 9 years ago

So the core mods argument makes your code work. Its now mine which is broken. :tada: :cake:. Thanks!

austinv11 commented 9 years ago

Yeah.. I have no idea why I have that recipe working like it is. I think I was just too lazy to make an IRecipe. Looks like I should probably change it. Anyways, have fun fixing stuff.

SquidDev commented 9 years ago

Note to self: Doesn't seem to save the binding.

@austinv11 Collective Framework is fixed now. Thanks!