Enter and Backspace not working in terminal in mincraft 1.14+ (maybe 1.13?)

SquidDev-CC / cloud-catcher

A web interface for ComputerCraft

https://cloud-catcher.squiddev.cc/

MIT License

53 stars 11 forks source link

Enter and Backspace not working in terminal in mincraft 1.14+ (maybe 1.13?) #18

Closed sir-maniac closed 4 years ago

sir-maniac commented 4 years ago

I didn't find any documentation mentioning it, do thought I'd file a bug report.

The remove terminal seems to work just fine, and I can type any letters or numbers, but the backspace and enter keys don't work. I have tried this on both Chrome v70 and Firefox v74 on linux.

SquidDev commented 4 years ago

Hrmr, that's very odd - I'm unable to reproduce on FF 75 (Windows), but fairly sure I've not had this issue on other versions either. Would you be able to try a couple of things:

Does the bug still reproduce on copy-cat? They use the same underlying web interface, so bugs in one should show up in the other.
Can you run the following program while true do print(os.pullEvent()) end and screenshot the result of pressing backspace and enter while doing so? Just so I can see if key events are getting incorrectly mapped.

sir-maniac commented 4 years ago

Copy-cat does work.

For the os.pullEvent, the enter and backspace register as different codes.

minecraft: Enter:257, Backspace:259 In firefox: Enter:28, backspace:14

BTW, the same keycodes show up in copy-cat:

EDIT: The same keycodes show in chrome

SquidDev commented 4 years ago

Oh, are you on Minecraft 1.14/1.15 by any chance?

sir-maniac commented 4 years ago

Oh, are you on Minecraft 1.14/1.15 by any chance?

Yes, I'm using 1.15.2

EDIT: Mods and their versions: CCTweaked: 1.15.2-1.86.2.

EDIT 2: the rest of the mods AppleSkin-mc1.15.2-forge-1.0.13 BetterAdvancements-1.15.2-0.1.0.96 'Clear Glass Pack 1.15+.zip' ClothConfig2-2.0 Controlling-6.1.1 CraftingTweaks_1.15.1-11.0.0 damage_indicator-0.0.9 FastLeafDecay-v20 'fWhip V1.1 1.15+.zip' inventorysorter-1.15.2-17.0.0 ironchest-1.15.2-10.0.3 Just Enough Items 1.15.2-6.0.0.2 LightOverlay-4.2 noRecipeBook_v1.5.2formc1.15.2 randompatches-1.15.2-1.21.1.0 ReAuth-1.14-3.8.0 ServerTabInfo-1.15.2-1.2.6 ShulkerTooltip-1.9.2 snowundertrees-1.15.1-v1.0 swingthroughgrass-1.15.2-1.4.0 vanilladeathchest-1.15.2-1.10.3.5 Xaeros_Minimap_FP20.1.0_Forge_1.15.2 XaerosWorldMap_1.5.4_Forge_1.15.2

This is mostly the forge mod pack "vanilla essentials" 1,15

SquidDev commented 4 years ago

Fantastic, thanks - Minecraft (and thus CC) changed their key maps in 1.13, but I never thought to handle it in cloud-catcher. Should be an easy enough fix.

sir-maniac commented 4 years ago

Just letting you know, I built master locally, and it seems to work fine. Thanks!

SquidDev commented 4 years ago

Fantantic! The website should be all updated too.