SquidDev-CC / plethora

A peripheral provider for ComputerCraft
https://plethora.madefor.cc/
MIT License
58 stars 22 forks source link

[Render distance issue] Overlay Glasses #150

Open Shiranuit opened 6 years ago

Shiranuit commented 6 years ago

Hey, it's me, again x)

So I've found an issue with the render distance of every objects 2d/3d when you set the point of origin with create(pos:table) or recenter() or recenter(pos:table) The render distance of the objects are based on player view distance and the player distance from the point of origin

Example:

Screnshots: At 0 block distance from the origin image At less than 32 blocks image At more than 32 blocks image

So the problem if you are at 32 blocks from the origin of the canvas, you can see a box a 64 blocks from the origin (at this point it's normal) but after 32 blocks from the origin you can't see the box This gap if even more big when you have a bigger render distance

My suggestion is to make the objects being rendered when they are in the render distance of the player from the player position instead of if the player distance from the canvas point of origin is less than the player render distance

SquidDev commented 6 years ago

I'm going to classify this as "sub-optimal intended behaviour". I'm very aware that this is a limitation, but it's also something I'm comfortable sticking with for the time being.

I've a couple of plans for the future of terminal glasses, which make this sort of problem much harder to solve:

It's possible I could just avoid doing such checks at all and render everything, though that then has a whole set of other issues with performance.

That being said, I'm definitely open if people have alternative ways this could be managed - I'm aware it's unideal, but it seems to be something which won't end up being a pain if I need to extend things later. It's generally easier to remove restrictions than add them back in.