Closed SquidDev closed 2 years ago
Having looked into this a little more and after running this on CC: Tweaked, the current system isn't really suitable. GITHUB_TOKEN
cannot be used to submit checks from forked repositories (as it has read-only permissions), and so illuaminate breaks.
I think the solution here is to strip out --github
support and build a separate executable which just contains the linters and GitHub communication. We can run the linter from an external service.
We removed GH support in 8c2ad23fa8569062e7c156a04b26700b5a78f37f. For CC:T, I've ended up registering a problem matcher instead, which works rather well.
I think I'm going to close this, as I don't think running an external service for this is worth it.
It would be nice to have integration with GitHub checks. We could have a
--github-checks
flag on Lint, which usesGITHUB_TOKEN
andGITHUB_REF
to send an API request.There's a nice example of a Robocop linter doing the same thing.
We could also use
requested_actions
to fix the issues, which would be neat.Lwt.t
(and so make the toplevel responsible for executing async code).