Squirrel / Squirrel.Mac

:shipit: Cocoa framework for updating OS X apps :shipit:
MIT License
1.59k stars 128 forks source link

Add auth headers to zip download requests not just feed requests. #190

Closed slyngbaek closed 7 years ago

slyngbaek commented 7 years ago

Our server checks the auth not just for checking the feed but also actually downloading the zip. It would be helpful if we could set headers on those requests as well.

slyngbaek commented 7 years ago

Regarding your initial comment, I could add another initializer or add a second argument to handle auth headers specifically

keithduncan commented 7 years ago

🤔 what do you think about a block argument in the initialiser NSURLRequest * (^requestForDownload)(NSURL *)?

joshaber commented 7 years ago

Awesome, thank you @slyngbaek!