Closed MarshallOfSound closed 6 years ago
Please note the only place this touches the existing code path is the modification of the cache policy and timeout. Neither of which should have any negative impacts on existing users.
Submodule changes are being reverted π
@joshaber Feedback addressed, the JSON structure is now in the README, it is also in the test docs π
Timeout removed and nil check comment addressed
Awesome!
What's the next step? Do we need to update Squirrel in https://github.com/electron/electron-frameworks ?
Yup! I'll make a release of Squirrel next week and then we'll need to make a new release with that.
This is the Hero We Deserveβ’
@joshaber is the Squirrel release process documented somewhere? Maybe I can take a shot at it?
Sorry for the delay!
It's not documented, but in theory it's carthage build --platform macos --no-skip-current && carthage archive
. Lemme know if you run into any trouble @zeke. I'm keen to enable you all as much as possible π
Ok, first question: what's carthage
:)
It's a dependency manager for Cocoa: https://github.com/Carthage/Carthage. You should be able to brew install carthage
.
It's a bit of a pain to build Squirrel.Mac locally, you need to be running an old XCode version π Here is a build from the latest master π
EDIT: To be exact you need XCode 8.2
Fixes #64
This PR supersedes #211 and contains just a few extra fixes on top of it to satisfy the outstanding comments from @joshaber