search

Squirrel / Squirrel.Mac

:shipit: Cocoa framework for updating OS X apps :shipit:
MIT License
1.57k stars 128 forks source link

Fix ShipIt dependency linking. #236

Closed devinfoley closed 4 years ago

devinfoley commented 5 years ago

A recent change to Squirrel attempted to link to ReactiveCocoa and Mantle in ShipIt, vs copying and compiling their source files into the ShipIt binary. This was done because, in certain environments, dylib was loading multiple copies of the classes, which was causing errors in ReactiveCocoa's assertions.

This PR actually removes the dependency classes from the Copy Files build step. It adds an additional build step to re-link ReactiveCocoa and Mantle, using @executable_path instead of @rpath, as @rpath linking was causing the same double loading problem in certain environments.

Neoster commented 5 years ago

When will this be merged? I think it will fix my issues i am having using Squirrel....

devinfoley commented 4 years ago

Closing because this is covered by #242