search

Squirrel / Squirrel.Mac

:shipit: Cocoa framework for updating OS X apps :shipit:
MIT License
1.57k stars 128 forks source link

Fix ShipIt linking. #242

Open devinfoley opened 4 years ago

devinfoley commented 4 years ago

Currently, ShipIt is compiled with the source of ReactiveCocoa and Mantle, vs linking the frameworks that are distributed with Squirrel. This causes some issues in certain environments, where ShipIt can't figure out which copy of the objects to use. This PR fixes that.

First, it takes out all of the Mantle and ReactiveCocoa from the "Copy Sources" build step in ShipIt. Next, it links against the Mantle and ReactiveCocoa frameworks in ShipIt. Lastly, it adds a post build stage to link the compiled ShipIt binary to the Mantle and ReactiveCocoa frameworks using their location when distributed in Squirrel.

mRs- commented 4 years ago

is there a plan to merge this?

DimitarNestorov commented 4 years ago

Shouldn't #236 be closed?

Stanzilla commented 3 years ago

@devinfoley any plans to merge this?