Regression in 1.7.0+ `%20` appearing again in executable filenames

Squirrel / Squirrel.Windows

An installation and update framework for Windows desktop apps

MIT License

7.31k stars 1.03k forks source link

Regression in 1.7.0+ `%20` appearing again in executable filenames #1141

Open BrandonSmith opened 7 years ago

BrandonSmith commented 7 years ago

Executable with spaces is unpacked with %20 in the file name. This issue was previously addressed in #650. It seems when the compression strategy went to 7-Zip and SharpCompress, the fix in #650 was lost and the %20 started showing up again.

And of course this messes with the AppUserModelId generated by Squirrel.Windows for shortcuts.

Thieum commented 5 years ago

@BrandonSmith is the regression still there in the latest version of Squirrel?

BrandonSmith commented 5 years ago

@Thieum I'm not in a position to test. I'm sorry.