search

Squirrel / Squirrel.Windows

An installation and update framework for Windows desktop apps
MIT License
7.4k stars 1.03k forks source link

MSI : Incorrect path to Deployment directory in Registry #1707

Open vernou opened 3 years ago

vernou commented 3 years ago

Squirrel version(s) 2.0.1

Description After installing the MSI, when a user logs on, nothing happens.

See the

Steps to recreate

  1. Generate MSI with Squirrel --releasify
  2. Install MSI
  3. Log on

Expected behavior When log on, the installation begin.

Actual behavior When log on, nothing happens.

Additional information After installation, the registry entry's command is :

"C:\Program Files (x86)\ Deployment\MyAppDeploymentTool.exe" --checkInstall

See the space in the folder Deployment. When I manually correct (remove the space) the registry entry, the installation begin.

Maybe this come from : https://github.com/Squirrel/Squirrel.Windows/blob/76c87af6f389bea69576c738ef46574b2945b0ba/vendor/wix/template.wxs#L16

The APPLICATIONROOTDIRECTORY need a title, but this isn't provided. In this case, the MSI create the registry entry and the folder with a space. But maybe Windows remove space at the start of repository folder and the registry entry don't match the renamed folder.

vernou commented 3 years ago

Solved. The title attribute in the nuspec file was empty.

Originally posted by @MiroljubA in https://github.com/Squirrel/Squirrel.Windows/issues/466#issuecomment-247322358

As this comment suggests , I miss the title in nuspec. After added this work as expected.

vernou commented 3 years ago

To avoid this problem in the future, a warning in case of absence would be nice.