search

Squirrel / Squirrel.Windows

An installation and update framework for Windows desktop apps
MIT License
7.23k stars 1.02k forks source link

Drop DeltaCompressionDotNet dependency #1748

Closed AArnott closed 2 years ago

AArnott commented 2 years ago

This may be reverted after https://github.com/taspeotis/DeltaCompressionDotNet/issues/17 is fixed. Closes #1716

AArnott commented 2 years ago

The build break will be resolved after #1746 is merged, or after I remove the nullable ref annotations from the inserted code.

AArnott commented 2 years ago

@anaisbetts So https://github.com/taspeotis/DeltaCompressionDotNet/pull/18 actually was resolved in the last 14 hours. Do you want me to revert this, which will remove the code it adds and bring back the dependency, or keep things as-is?

robmen commented 2 years ago

Given the lack of changes to the code over time and the fact that everything is ILMerged in the end, I'm inclined to keep the PInvokes as they are now.