search

Squirrel / Squirrel.Windows

An installation and update framework for Windows desktop apps
MIT License
7.36k stars 1.03k forks source link

GetShortcutsForExecutable doesn't set the ShortCutFile path #637

Open LaviniaC opened 8 years ago

LaviniaC commented 8 years ago

It calculates, logs it but does not set it.

anaisbetts commented 8 years ago

ShortCutFile is only set when the shortcut is already existing, and GetShortcutsForExecutable returns the shortcut that would be created. Or are you saying that you want to know where we would put the shortcut?

LaviniaC commented 8 years ago

Yes, I would. In my particular case I just want to change a small part of it (a rename). I see no harm in having it set

anaisbetts commented 8 years ago

@LaviniaC I think you'll probably have to return it as a separate thing, but I'm totally :+1: for the idea. Can you submit a PR to this effect?

DanielRivers commented 8 years ago

I am not sure that it is setting set if already existing ...

mgr.CreateShortcutsForExecutable("Startup.exe", ShortcutLocation.Desktop | ShortcutLocation.StartMenu, false, null, null); var test = mgr.GetShortcutsForExecutable("Startup.exe", ShortcutLocation.Desktop | ShortcutLocation.StartMenu | ShortcutLocation.Startup, null).ToList();

I run the above lines, and still in the GetShortcutsForExecutable results ShortCutFile is empty