search

SrBrahma / GitHub-Repository-Manager

VS Code Extension to quickly clone, initialize and open your GitHub repositories
MIT License
31 stars 14 forks source link

feat: add one click clone option #7

Closed jonathan-fielding closed 4 years ago

jonathan-fielding commented 4 years ago

This pull request will add an option to always clone to the same location which means you can do one click cloning, click a repo and it clones 🤗

SrBrahma commented 4 years ago

Nice! Some time ago, I tried to implement it as a context menu option that would show a option to do it, with the path to the default clone destination. However, I couldn't find a way to inject variables into the context menu options (neither could find an extension that did this) and never thought of this again.

What happens when the git.defaultCloneDirectory isn't set and you try to clone it to the default dir? I would check myself, but this quarantine really took away all my will to handle the extension :/

jonathan-fielding commented 4 years ago

Good spot, that is something I didn't handle, will make a change that means the setting does nothing if default dir not set

jonathan-fielding commented 4 years ago

When testing it looks like defaultCloneToDir always has a value even if its not explicitly set, by default it looks like its my home directory but it means this PR is still valid.

Also hope everything quarantine wise is ok where you are, 🤗, wish you all the best