search

SrBrahma / react-native-gev

MIT License
3 stars 1 forks source link

Remove theme? #13

Open SrBrahma opened 2 years ago

SrBrahma commented 2 years ago

It seems that the only reason I created createTheme/useTheme is to allow light, dark etc themes. We could then changeTheme() to change from light to dark, and all the components with useTheme would refresh.

But, useTheme isn't cool. It adds complexity to the components. Changing theme isn't common -- having more than one theme isn't already common at all in apps.

If the user changes the theme, we can just reset the app, or have a hook in root's level to watch it.

SrBrahma commented 2 years ago

But, if we remove it it would also remove the possibility of a default font for Texts.