SrNightmare09 / chess-fen-reader

A simple FEN reader which generates a chessboard
MIT License
2 stars 4 forks source link

Feature Addition: Numbers and Letters on side of board #20

Closed AmitT98 closed 1 year ago

AmitT98 commented 1 year ago

I have added the numbers and alphabets by modifying the index.html and style.css file. Below is how is looks, image Let me know if this is good enough so that I can raise a PR.

SrNightmare09 commented 1 year ago

I have added the numbers and alphabets by modifying the index.html and style.css file. Below is how is looks, image Let me know if this is good enough so that I can raise a PR.

Looks great! Here are a few more suggestions:

AmitT98 commented 1 year ago

I made the changes. Take a look,

https://github.com/SrNightmare09/chess-fen-reader/assets/104303111/4bb6dab2-a992-4302-be00-d00ed886b063

SrNightmare09 commented 1 year ago

@AmitT98 looks great! but I would like to see the letters having gap between the board like the numbers do, and if possible, it would be nice to see each letter aligned to the center of the cell (like the numbers). if you feel like it is not required, feel free to tell me and I will be happy to receive a PR anyway! :)

AmitT98 commented 1 year ago

Hi @SrNightmare09 I have made centre align change as well in my local repo. However the current state of code in master is somewhat not rendering properly. Can you you check it once at your end. For me it shows like this. image

SrNightmare09 commented 1 year ago

@AmitT98 The code works perfectly fine on my end.

AmitT98 commented 1 year ago

Yes now it now renders correctly for me as well. By the way, I made the necessary changes and raised a PR.