Embeddium+ breaks chest animation

SrRapero720 / EmbeddiumAdditions

Additions for Embeddium and Sodium that should be added on it but can't be (spiritual successor of Embeddium++)

14 stars 0 forks source link

Embeddium+ breaks chest animation #6

Open Aarods opened 7 months ago

Aarods commented 7 months ago

When installing the latest version of Embeddium++ (1.18.2/v1.2.3), the chest animation breaks, with or without the "Fast Chests" option activated. (I also have the mod of "Enhanced Block Entities", but this error shows by default without the mod installed as well)

Kasualix commented 7 months ago

Registering the assets/minecraft stuff as a resourcepack and (in)validating it when necessary can perhaps resolve this.

SrRapero720 commented 7 months ago

@Kasualix i like your idea, but i preffer have toggle placed on video settings and no make users to toggle off fast chest and also go to resourcepacks to disable fast chests....

at the moment, my plan was handle when emb++ resources are begin (re)loaded and invalidate them when fast chests options is disabled...

for now. i mark this as Help wanted because i have no much idea how to archieve that

Kasualix commented 7 months ago

i preffer have toggle placed on video settings and no make users to toggle off fast chest and also go to resourcepacks to disable fast chests....

Perhaps the deletion logic can be impl here, and we can add REQUIRE_ASSETS_RELOAD flag so the user don't need to change to resourcepacks page