search

SrRapero720 / waterframes

Mod which let you see pictures in-game amen
24 stars 13 forks source link

Suggestion: option in the displays to mute Minecraft BGM while in it's sound range #112

Closed diefesson closed 2 months ago

diefesson commented 2 months ago

Problem: sometimes both the display and Minecraft BGM plays at same time resulting in the display sound being hard to understand.

Current: currently the solution requires ever player in range manually muting they BGM. Harming user experience

Improvement: option in the displays to mute Minecraft BGM while in it's sound range

SrRapero720 commented 2 months ago

i will look into it

SrRapero720 commented 2 months ago

Here is the patch disable_minecraft_background_music_when_WF_displays_is_nearby.patch

i decided to not integrate this yet because i don't feel confortable. Honestly end-user must mute BG music.

sorry but i will not integrate this