search

SrS2225a / custom_uploader

Custom Uploader is a simple, lightweight, and easy to use file uploader built using flutter for android devices that allows you to upload files to a file host of your choice.
MIT License
39 stars 2 forks source link

Support IP addresses in URL's #6

Closed mhio closed 6 months ago

mhio commented 7 months ago

Describe The Bug

Setting up a host with http://192.168.1.100/ results in an "Please enter a valid url" validation message.

The regex is a bit restrictive, even for tlds

Some samples: https://regexr.com/7ooub

To Reproduce

Open "Add" form.

Enter URLS like:

Expected Behavior

Valid URLs validate

Screenshots

No response

OS Version

No response

App Version

1.1.0

SrS2225a commented 7 months ago

Thanks for your report. It did not cross my mind at the time to support regular ip addresses than just domains, and the http:// restriction is because of the http library I use. I will take a look at it and should be fixed in the next app version with your improvements which is coming soon.

SrS2225a commented 6 months ago

Thanks for bearing with me, the bug you reported has been fixed, and Custom Uploader will now support ip's. You should see the new version on F-Droid soon