SrainApp / srain

Modern IRC client written in GTK
https://srain.silverrainz.me/
Other
309 stars 35 forks source link

log = false not works #402

Closed misterhsp closed 9 months ago

misterhsp commented 9 months ago

I have set 'log = false' (chat log) in the srain.cfg. But the chatlog is still written to ~/.local/share/srain/logs. I would like to turn this off.

/hsp

SilverRainZ commented 9 months ago

Can you paste your srain.cfg?

misterhsp commented 9 months ago

srain.cfg:

https://pastebin.com/d5KeRC8A

Am 10.02.24 um 15:34 schrieb Shengyu Zhang:

Can you paste your |srain.cfg|?

— Reply to this email directly, view it on GitHub https://github.com/SrainApp/srain/issues/402#issuecomment-1937021708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKGJLRLW7V2XUTT34ZSZRB3YS6AQTAVCNFSM6AAAAABDCVF5Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGAZDCNZQHA. You are receiving this because you authored the thread.Message ID: @.***>

SilverRainZ commented 9 months ago

Sorry, I forgot that this function is not implemented in the code.

https://github.com/SrainApp/srain/blob/7c81bed1cffac7b5ca2aba1d3d287b77d3b1abb1/src/inc/core/chat.h#L72-L79

SilverRainZ commented 9 months ago

https://github.com/SrainApp/srain/pull/403 should works, will be released as part of 1.6.0

misterhsp commented 9 months ago

meson.build has wrong version

[...]

prooject(     'srain', 'c', -   version: '1.5.1', +  version: '1.6.1',     license: 'GPL3',     meson_version: '>= 0.47.0' )

[...]

Am 11.02.24 um 07:17 schrieb Shengyu Zhang:

Closed #402 https://github.com/SrainApp/srain/issues/402 as completed via #403 https://github.com/SrainApp/srain/pull/403.

— Reply to this email directly, view it on GitHub https://github.com/SrainApp/srain/issues/402#event-11766349208, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKGJLRIWJL6GOYGCAROOOHTYTBO7HAVCNFSM6AAAAABDCVF5Q2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG43DMMZUHEZDAOA. You are receiving this because you authored the thread.Message ID: @.***>

SilverRainZ commented 9 months ago

@misterhsp thanks for pointing this out. Since it wasn't that long since the release, I recreated the tag