Sui(impl): Add chat list order configuration

SrainApp / srain

Modern IRC client written in GTK

https://srain.silverrainz.me/

Other

303 stars 34 forks source link

Closed Exagone313 closed 3 weeks ago

Exagone313 commented 1 month ago

Adds a way to sort channels alphabetically in the sidebar

Notes for the review:

I am not quite sure about the naming
There are no checks done on the new sidebar-sort configuration value, but no other settings appear to have such checks. The default value I have provided in builtin.cfg is de facto arbitrary.
I wonder if there is a better way to access the configuration from list_sort_func
It's possible that I have missed some error checks to be done

SilverRainZ commented 1 month ago

Sorry for replying so late, just fired by my employer recently :-P

Exagone313 commented 3 weeks ago

@SilverRainZ I updated it.