search

Sranshaft / skin.immersive

A skin for Kodi using Microsoft's Universal Windows Application design guidelines
Other
40 stars 17 forks source link

Skin Changing chrashes Skin [Openelec] #40

Closed wilderkaiser closed 10 years ago

wilderkaiser commented 10 years ago

Changing to a diffrent Skin chrashes the Skin (BlackScreen with Cross) .. then the Skin reboots ... Bad situation ...

Kind regards

twjacobsen commented 10 years ago

OpenElec, Raspberry Pi, Latest Gotham nightly.

Seems as if the skin crashes whenever a "select something" dialog should show. Crashes both when trying to selec another skin, or when trying to select languages when setting up subtitles addon. Also crashes when configuring the skin, trying to select subtitle addon.

XBMC logs shows nothing useful (tried figuring it out using tail -f xbmc.log)...

hessius commented 10 years ago

I've managed to select subtitle add-on but xbmc crashes when trying to change subtitle offset; Using the SPMC build (based off latest gotham monthly) on OUYA

Sranshaft commented 10 years ago

There seems to an issue with the newer OpenElec builds; an issue that isn't found on other builds.

It's being tracked down and someone has posted a dirty fix on the forum. I haven't tested it yet but apparently it works.

http://forum.xbmc.org/showthread.php?tid=175268&pid=1535728#pid1535728

I've started work on updating to Gotham so hopefully I'll be able to fix it. Until then, Immersive is only officially compatible with Frodo. YMMV when using a different build.

jmarshallnz commented 10 years ago

@Sranshaft: The issue is a neat infinite loop you've managed to construct :)

DialogSelect.xml contains a label with id 1 that has <label>Control.GetLabel(1)</label> in it, which causes quite a neat infinite loop (as GetLabel calls GetLabel which calls GetLabel...)

I suspect you want to drop the id="1" from the label (and leave it on the heading one further down in the XML).

Unfortunately this is hard/impossible to detect XBMC-side, so we can't do much to protect you here.

Sranshaft commented 10 years ago

@jmarshallnz: Thanks for pointing me in the right direction. Odd that the loop doesn't cause other builds to crash. I suppose OpenElec is less forgiving with this sort of issue. Completely understandable that XBMC doesn't / can't check for loops like this but it's something I should have picked up on a long time ago.

Will push a fix shortly.

jmarshallnz commented 10 years ago

No problem. It crashed first time for me on OS X. Reason noone else picked it up is that the number of Gotham users of OpenElec completely swamps the other platforms (as OpenElec pushes releases that are more often on the cutting edge).

Sranshaft commented 10 years ago

@jmarshallnz: Strange through that it crashes Gotham but wasn't an issue with Frodo. That part of code with the infinite loop has been included with Immersive since I originally released it I believe. It's only until the latest versions of Gotham that it's been noticed.

I've been keeping up to date with the feature changes regarding Gotham but haven't had the time to look at the underlying changes to the code. It'll be interesting to see if any other issues start to crop up that might have been overlooked due to not really being an issue with Frodo going forward.

mvdwetering commented 10 years ago

Just FYI, I am seeing the XBMC crashes when attempting to change a skin on OpenELEC 3.2.3 which has Frodo 12.2, so it is not limited to Gotham. I already noticed it a while ago, but forgot to report it :-(

Didn't try the new version yet

wilderkaiser commented 10 years ago

i can confirm this ...