search

Sranshaft / skin.immersive

A skin for Kodi using Microsoft's Universal Windows Application design guidelines
Other
40 stars 17 forks source link

Addons browser corrections + PVR changes #57

Closed herrJones closed 10 years ago

herrJones commented 10 years ago

PVR changes = same as before but now in the master-branch

Addons browser:

Weather (alert) : widen up label

Settings menu: show (dark) clock

Kind regards,

Jan
Sranshaft commented 10 years ago

Thanks for taking the time to submit the PR but I can't accept it. It simply changes too many things all at once. I've gone through the PR in its entirety and have cherry picked the PVR additions although with some code clean-up and changes of my own.

I will have to reject the AddonBrowser changes though. I have fixed the issue with the text colour when using the Details view. The rest of the changes were unnecessary.

The clock on the settings screen will have to be rejected at this moment as well.

In the future, if you can submit a PR for each individual change so that I can accept or reject on a change-by-change basis that would be great. Saves me having the reject the entire PR even if there is something that could very well be included.