search

Sranshaft / skin.immersive

A skin for Kodi using Microsoft's Universal Windows Application design guidelines
Other
40 stars 17 forks source link

included MediaBrowser support for Movies and TV-Shows #78

Closed marcelveldt closed 9 years ago

marcelveldt commented 9 years ago

Hi! I have added support for MediaBrowser libraries in a separate branch of your skin. Are you willing to add this to your main version ? Also, I'm happy to help you wherever I can, also to maintain the MediaBrowser support.

Kind regards,

Marcel

Sranshaft commented 9 years ago

A big thanks for adding support for Media Browser. I'll have a closer look at the PR but at first glance everything looks okay to be merged. I'm waiting for the internet to be connected at my new place but once that is finished I'll merge what commits I have waiting and merge your PR.

lavvy commented 9 years ago

Hey guys, if I want a button on the skin to call a function in a python file like default.py at an onclick event, how do I do that on the xml like home.xml On Oct 15, 2014 9:54 AM, "Sranshaft" notifications@github.com wrote:

A big thanks for adding support for Media Browser. I'll have a closer look at the PR but at first glance everything looks okay to be merged. I'm waiting for the internet to be connected at my new place but once that is finished I'll merge what commits I have waiting and merge your PR.

— Reply to this email directly or view it on GitHub https://github.com/Sranshaft/skin.immersive/pull/78#issuecomment-59208359 .

marcelveldt commented 9 years ago

Hi Sranshaft, Thanks! That's really great to hear. For your reference: your skin is now available on the MediaBrowser repo along with other skins that are made compatible. Please let me know if you want to keep it that way.

Sranshaft commented 9 years ago

@marcelveldt: As long as the version on the MediaBrowser repo is kept up to date I'm happy with that.

Any chance you can add MediaBrowser support for the rest of the media; ie: Music, pictures, etc. I'm fine with merging what you have so far but would feel better if there was full support.

marcelveldt commented 9 years ago

@Sranshaft : Yes I will do that later this week. Do you like to receive access to the repo to update the skin yourself ? Or do you allready post your skin somewhere on a repo ?

In hat case, it's better to remove the duplicate in XBMB3C repo after you've merged the additions so users have a central place to download and get support.

Sranshaft commented 9 years ago

@marcelveldt: I recently pushed all awaiting commits I had created during the move. If you can rebase against the current master branch I'll merge the PR.

Also, I noticed in the Mediabrowser thread there was a couple users that were having trouble getting movies and TV shows to appear on the home screen - the setting for their respective menu item was disabled. You'll need to adjust the menu items' enable tag to reflect the new usage.

Should look something like Library.HasContent(movies) | Skin.HasSetting(HomeMenuUseMBforMovies) for the enable tag. The same should be done for the TV show menu item.

marcelveldt commented 9 years ago

ok, will do that. Thanks for the heads up